[cfe-commits] r83929 - in /cfe/trunk/test: CodeGen/blocks-2.c CodeGenObjC/PR4894-recursive-debug-crash.m

[Devang Patel]

On Oct 25, 2009, at 2:40 PM, Daniel Dunbar wrote:

> Hi Devang,
>
> On Mon, Oct 12, 2009 at 4:46 PM, Devang Patel <dpatel at apple.com>  
> wrote:
>> Author: dpatel
>> Date: Mon Oct 12 18:46:58 2009
>> New Revision: 83929
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=83929&view=rev
>> Log:
>> Disable tests that check debug info intrinsic. This does not work  
>> if debug info intrinsics are not used to encode debug info.
>
> This is inappropriate, I think. Unless you plan on bringing debug info
> intrinsics back, then these tests should be updated not XFAILed.
>

I have not removed intrinsics supported yet from code base (it is  
#ifdef'ed out right now.) Once the transition is complete, I'll update  
all debug info tests from clang as well as llvm test suite. These  
tests fall in three broad category.

1. Check quality of debug info produced by the tool chain.
2. Check implementation of debug info support in the tool chain.
3. Check debug info intrinsic implementation (creation, preservation,  
lowering etc..) in llvm code base.

Ideally tests from 2nd category will stay in clang test suite. Tests  
from 3rd category will disappear. And tests from 1st category will  
find a new home.

-
Devang