[cfe-commits] mark vtables linkonce_odr

Mike Stump mrs at apple.com
Mon Oct 26 05:25:26 PDT 2009


On Oct 25, 2009, at 11:54 PM, Nick Lewycky wrote:
> I was looking at Clang output for C++ code and noticed that we were  
> emitting vtables with 'weak' linkage. From what I can see, clang  
> already has the full declaration when it goes to emit the vtable,  
> and should be using 'linkonce_odr' which gives LLVM some hope of  
> devirtualizing.
>
> Is that correct? If so, the attached patch makes the 1-line change  
> to make it so. Please review!

Looks fine to me.



More information about the cfe-commits mailing list