[cfe-commits] [PATCH] fixes PR5206

Daniel Dunbar daniel at zuster.org
Sun Oct 25 15:31:07 PDT 2009


Hi Zhanyong,

2009/10/15 Zhanyong Wan (λx.x x) <wan at google.com>:
> 2009/10/15 Anders Carlsson <andersca at mac.com>:
>> Hi Zhanyong!
>>
>> I did not see your patch and committed a similar fix. Sorry about that! (Fix
>> looks great though :)
>
> No problem.  Glad it's fixed now.
>
> I'm wondering how the clang community coordinates effort.  How do we
> prevent duplicated work?  I assigned the bug to myself - is there
> anything else I should do to indicate that I was working on it?
> Thanks,

Currently, we don't really do much in the way of coordination. Our
community is small enough that most of the active contributors "just
know" what other people are working on, and a lot of us are on the
#llvm IRC channel. We don't generally use the "assigned to" field in
bugzilla, so people aren't used to checking it. If you are working on
a particular bugzilla, its probably best to add a comment that says
"I'm working on this".

 - Daniel

>>
>> Anders
>>
>> 15 okt 2009 kl. 17.01 skrev Zhanyong Wan (λx.x x):
>>
>>> Can someone review this?  Thanks.
>>>
>>> C++ 5.[14,15]: the && and || operators produce a bool.
>>>
>>> C has no bool type and thus the rule is different there:
>>>
>>> C99 6.5.[13,14]: the && and || operators produce an int.
>>>
>>> Currently clang always thinks the result is an int (the C99 behavior).  It
>>> should consider the result type bool in C++ mode.
>>>
>>> --
>>> Zhanyong
>>> <pr5206.patch>_______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
>
>
> --
> Zhanyong
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>




More information about the cfe-commits mailing list