[cfe-commits] r84955 - in /cfe/trunk: lib/Sema/SemaExprCXX.cpp test/CodeGenCXX/ptr-to-member-function.cpp

[Fariborz Jahanian]

Author: fjahanian
Date: Fri Oct 23 13:08:22 2009
New Revision: 84955

URL: http://llvm.org/viewvc/llvm-project?rev=84955&view=rev
Log:
Fixed a code gen bug (by fixing the AST) involving user-defined
pointer-to-member type conversion follwed by a pointer-to-member
standard conversion.


Added:
    cfe/trunk/test/CodeGenCXX/ptr-to-member-function.cpp
Modified:
    cfe/trunk/lib/Sema/SemaExprCXX.cpp

Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=84955&r1=84954&r2=84955&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Fri Oct 23 13:08:22 2009
@@ -1139,6 +1139,10 @@
         From = CastArg.takeAs<Expr>();
         return BuildCXXDerivedToBaseExpr(From, CastKind, ICS, Flavor);
       }
+    
+      if (ICS.UserDefined.After.Second == ICK_Pointer_Member &&
+          ToType.getNonReferenceType()->isMemberFunctionPointerType())
+        CastKind = CastExpr::CK_BaseToDerivedMemberPointer;
       
       From = new (Context) ImplicitCastExpr(ToType.getNonReferenceType(),
                                             CastKind, CastArg.takeAs<Expr>(),

Added: cfe/trunk/test/CodeGenCXX/ptr-to-member-function.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/ptr-to-member-function.cpp?rev=84955&view=auto

==============================================================================
--- cfe/trunk/test/CodeGenCXX/ptr-to-member-function.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/ptr-to-member-function.cpp Fri Oct 23 13:08:22 2009
@@ -0,0 +1,53 @@
+// RUN: clang-cc -triple x86_64-apple-darwin -std=c++0x -S %s -o %t-64.s &&
+// RUN: FileCheck -check-prefix LP64 --input-file=%t-64.s %s &&
+// RUN: clang-cc -triple i386-apple-darwin -std=c++0x -S %s -o %t-32.s &&
+// RUN: FileCheck -check-prefix LP32 --input-file=%t-32.s %s &&
+// RUN: true
+// 13.3.3.2 Ranking implicit conversion sequences
+
+extern "C" int printf(...);
+
+struct A {
+int Ai;
+}; 
+
+struct B : public A {
+  void bf() { printf("B::bf called\n"); }
+}; 
+
+struct C : public B { }; 
+
+// conversion of B::* to C::* is better than conversion of A::* to C::*
+typedef void (A::*pmfa)();
+typedef void (B::*pmfb)();
+typedef void (C::*pmfc)();
+
+struct X {
+	operator pmfa();
+	operator pmfb() {
+	  return &B::bf;
+        }
+};
+
+
+void g(pmfc pm) {
+  C c;
+  (c.*pm)();
+}
+
+void test2(X x) 
+{
+    g(x);
+}
+
+int main()
+{
+	X x;
+	test2(x);
+}
+
+// CHECK-LP64: call	__ZN1XcvM1BFvvEEv
+// CHECK-LP64: call	__Z1gM1CFvvE
+
+// CHECK-LP32: call	L__ZN1XcvM1BFvvEEv
+// CHECK-LP32: call	__Z1gM1CFvvE