[cfe-commits] [PATCH] Diagnostics::pushMappings fix for VC++

Chris Lattner clattner at apple.com
Thu Oct 22 19:03:35 PDT 2009

On Oct 22, 2009, at 6:54 PM, John Thompson wrote:

> On Windows there was an ordering problem in the push_back if the  
> internal array needed growing, copying an element already deleted in  
> the grow (I think).  With your approval, I'll check it in.  This  
> will fix an assert in running the Preprocessor/pushable- 
> diagnostics.c test on Windows.

Looks great to me.  The problem is not MSVC specific, please change  
the comment to say it "avoids undefined behavior when the stack has to  
resize" or something like that.


> -John
> -- 
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> <diagnosticfix.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091022/15b1b4c1/attachment.html>

More information about the cfe-commits mailing list