[cfe-commits] [patch] Refactor the include search into different c, c++ and framework functions

Rafael Espindola espindola at google.com
Wed Oct 21 21:03:42 PDT 2009


The attached patch refactors AddDefaultSystemIncludePaths by adding
helper functions for c, c++ and framework. The only user visible
differences should be

*) Frameworks are only searched on OS X
*) The Cygwin c++ headers are now marked as c++ aware. I am almost
sure that not marking them was a bug.

One reason for doing this is just that the current functions was
getting large and with lots of nesting. Another, probably more
important, reason is that I want to add support for defining search
paths at compile time. With this refactoring this will look like

...AddDefaultCIncludePaths(..) {
  If (configure option for C set)  {
   use it.
   return;
   }
  current run time search.
}

And similarly for c++ and maybe frameworks (if those two paths are not
the only ones ever used....).

Comments?

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: search.patch
Type: application/octet-stream
Size: 13796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20091022/c89900d2/attachment.obj>


More information about the cfe-commits mailing list