[cfe-commits] r84393 - /cfe/trunk/lib/Sema/SemaExpr.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Sat Oct 17 21:09:38 2009
New Revision: 84393

URL: http://llvm.org/viewvc/llvm-project?rev=84393&view=rev
Log:
Add another two ExtVectorComponent FIXMEs.

Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=84393&r1=84392&r2=84393&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Sat Oct 17 21:09:38 2009
@@ -1877,6 +1877,11 @@
 CheckExtVectorComponent(QualType baseType, SourceLocation OpLoc,
                         const IdentifierInfo *CompName,
                         SourceLocation CompLoc) {
+  // FIXME: Share logic with ExtVectorElementExpr::containsDuplicateElements,
+  // see FIXME there.
+  //
+  // FIXME: This logic can be greatly simplified by splitting it along
+  // halving/not halving and reworking the component checking.
   const ExtVectorType *vecType = baseType->getAs<ExtVectorType>();
 
   // The vector accessor can't exceed the number of elements.