[cfe-commits] r81599 - in /cfe/trunk/lib/CodeGen: CGBlocks.cpp CGDecl.cpp CodeGenFunction.h

[Chris Lattner]

On Sep 14, 2009, at 9:58 AM, Anders Carlsson wrote:

>>> URL: http://llvm.org/viewvc/llvm-project?rev=81599&view=rev
>>> Log:
>>> For __block variables, cache the LLVM types as well as which LLVM  
>>> field where the variable is stored.
>>
>> Does this need to use PATypeHolder?  What if a type gets laid out  
>> and refines another type in the vector?
>
> I don't see how that could happen - the variable will never need to  
> be refined (I think :)

I'm not sure that it can: does the code convert an AST type to an LLVM  
type while the vector is live?  If so, that can cause type refinement.

-Chris