[cfe-commits] r81070 - /cfe/trunk/lib/CodeGen/Mangle.cpp

[John McCall]

Mike Stump wrote:
> On Sep 5, 2009, at 12:57 PM, John McCall wrote:
>> I very much doubt that twines would be anything but a pessimization, but
>> if someone wants to write a twine stream,
>
> No, that point is we do all this work to create a twine.  If the 
> mangler created a twine directly... we wouldn't need a stream.

Believe it or not, I understand that it is possible to rewrite the 
mangler to explicitly build twines instead of copying characters into a 
buffer.  What I am saying is that we probably don't want to, and even if 
we do, we can just do it by writing a stream that builds twines.  I 
don't see the advantage of restructuring everything to avoid the stream 
abstraction.

John.