[cfe-commits] r80787 - in /cfe/trunk: include/clang-c/Index.h tools/CIndex/CIndex.cpp tools/c-index-test/c-index-test.c

[steve naroff]

Hi Daniel,

On Sep 2, 2009, at 12:38 PM, Daniel Dunbar wrote:

> Hi Steve,
>
> On Wed, Sep 2, 2009 at 6:28 AM, Steve Naroff<snaroff at apple.com> wrote:
>> +    enum CXCursorKind filterData = CXCursor_FieldDecl;
>> +    clang_loadDeclaration(Cursor.decl, DeclVisitor, 0);
>
> filterData is dead?

This is just a simple test harness that I'm using for testing. Once  
the dust settles, I'll clean this up...

>
>> +  enum CXCursorKind filterData = CXCursor_StructDecl;
>> +  clang_loadTranslationUnit(TU, TranslationUnitVisitor, 0);
>
> and here.
>
> Also watch out for:
> --
> c-index-test.c:26: warning: ISO C90 forbids mixed declarations and  
> code
> --
>
> Actually, maybe we should just make this file a .cpp? Just because it
> is testing the C API doesn't mean it has to be C itself.

I'd prefer we stick with C (to better reflect what our current clients  
are doing).

For example, C doesn't like C++ style comments. If I were using C++, I  
wouldn't catch silly stuff like that...

snaroff

>
> - Daniel