[cfe-commits] r80701 - in /cfe/trunk: lib/CodeGen/CGCXX.cpp test/CodeGenCXX/destructors.cpp

Anders Carlsson andersca at mac.com
Tue Sep 1 14:11:34 PDT 2009


On Sep 1, 2009, at 11:37 AM, Mike Stump wrote:

> On Sep 1, 2009, at 11:33 AM, Anders Carlsson wrote:
>> Author: andersca
>> Date: Tue Sep  1 13:33:46 2009
>> New Revision: 80701
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=80701&view=rev
>> Log:
>> We can generate constructors/destructors with base classes and non- 
>> trivial fields just fine now.
>
>> -  // The class has base classes - we don't support that right now.
>> -  if (RD->getNumBases() > 0)
>> -    return false;
>
> getNumVBases() > 0?  We don't yet do all the right things there yet...

I added

   assert(!ClassDecl->getNumVBases() &&
          "FIXME: Destruction of virtual bases not supported");

to EmitDtorEpilogue. I couldn't add the same assert to  
EmitCtorPrologue since that broke virt.cpp

Anders




More information about the cfe-commits mailing list