[cfe-commits] r80064 - in /cfe/trunk: lib/CodeGen/CGCXX.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/virt.cpp

[Douglas Gregor]

On Aug 26, 2009, at 1:51 PM, Mike Stump wrote:

> On Aug 25, 2009, at 7:58 PM, Douglas Gregor wrote:
>> Checking that this is a reference to a virtual method is necessary,  
>> but not sufficient. We also need to check that the name was not  
>> qualified, e.g.,
>
> Fixed by putting in the code, commented out, but with a FIXME.
>
> struct test12_A {
>  virtual void foo0() { }
>  virtual void foo();
> } *test12_pa;
>
> void foo() {
>  test12_pa->test12_A::foo();
> }
>
> -ast-prints as:
>
> void foo() {
>    test12_pa->foo();
> }
>
> :-(

Would you prefer:

void foo() {
     test12_pa->test12_A::foo();
}

?

Anyway, there's a request in here

	http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090824/020686.html

for you to write a test case that makes sure we do the right thing in  
CodeGen.

	- Doug