[cfe-commits] r79986 - in /cfe/trunk: lib/Sema/SemaDeclCXX.cpp test/SemaTemplate/default-expr-arguments.cpp

[Anders Carlsson]

Author: andersca
Date: Tue Aug 25 08:46:13 2009
New Revision: 79986

URL: http://llvm.org/viewvc/llvm-project?rev=79986&view=rev
Log:
If a parameter has a default argument expression, make sure to instantiate the parameter type before checking that the expression is a valid initializer.

Modified:
    cfe/trunk/lib/Sema/SemaDeclCXX.cpp
    cfe/trunk/test/SemaTemplate/default-expr-arguments.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=79986&r1=79985&r2=79986&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Tue Aug 25 08:46:13 2009
@@ -107,6 +107,12 @@
 {
   QualType ParamType = Param->getType();
 
+  if (RequireCompleteType(Param->getLocation(), Param->getType(),
+                          diag::err_typecheck_decl_incomplete_type)) {
+    Param->setInvalidDecl();
+    return true;
+  }
+
   Expr *Arg = (Expr *)DefaultArg.get();
   
   // C++ [dcl.fct.default]p5

Modified: cfe/trunk/test/SemaTemplate/default-expr-arguments.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/default-expr-arguments.cpp?rev=79986&r1=79985&r2=79986&view=diff

==============================================================================
--- cfe/trunk/test/SemaTemplate/default-expr-arguments.cpp (original)
+++ cfe/trunk/test/SemaTemplate/default-expr-arguments.cpp Tue Aug 25 08:46:13 2009
@@ -26,3 +26,11 @@
 void g2() {
 	F<int> f;
 }
+
+template<typename T> struct G {
+	G(T) {}
+};
+
+void s(G<int> flags = 10) { }
+
+