[cfe-commits] r79974 - in /cfe/trunk/lib/Sema: Sema.h SemaExpr.cpp

[Anders Carlsson]

Author: andersca
Date: Mon Aug 24 22:49:14 2009
New Revision: 79974

URL: http://llvm.org/viewvc/llvm-project?rev=79974&view=rev
Log:
Factor building of CXXDefaultArgExpr expressions out into a separate function.

Modified:
    cfe/trunk/lib/Sema/Sema.h
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/Sema.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.h?rev=79974&r1=79973&r2=79974&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/Sema.h (original)
+++ cfe/trunk/lib/Sema/Sema.h Mon Aug 24 22:49:14 2009
@@ -1763,6 +1763,12 @@
                               bool Elidable,
                               Expr **Exprs, unsigned NumExprs);
   
+  /// BuildCXXDefaultArgExpr - Creates a CXXDefaultArgExpr, instantiating
+  /// the default expr if needed.
+  OwningExprResult BuildCXXDefaultArgExpr(SourceLocation CallLoc,
+                                          FunctionDecl *FD,
+                                          ParmVarDecl *Param);
+  
   /// FinalizeVarWithDestructor - Prepare for calling destructor on the
   /// constructed variable.
   void FinalizeVarWithDestructor(VarDecl *VD, QualType DeclInitType);

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=79974&r1=79973&r2=79974&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Mon Aug 24 22:49:14 2009
@@ -2429,6 +2429,57 @@
   return ExprError();
 }
 
+Sema::OwningExprResult Sema::BuildCXXDefaultArgExpr(SourceLocation CallLoc,
+                                                    FunctionDecl *FD,
+                                                    ParmVarDecl *Param) {
+  if (Param->hasUnparsedDefaultArg()) {
+    Diag (CallLoc,
+          diag::err_use_of_default_argument_to_function_declared_later) <<
+      FD << cast<CXXRecordDecl>(FD->getDeclContext())->getDeclName();
+    Diag(UnparsedDefaultArgLocs[Param], 
+          diag::note_default_argument_declared_here);
+  } else {
+    if (Param->hasUninstantiatedDefaultArg()) {
+      Expr *UninstExpr = Param->getUninstantiatedDefaultArg();
+
+      // Instantiate the expression.
+      const TemplateArgumentList &ArgList = getTemplateInstantiationArgs(FD);
+      
+      // FIXME: We should really make a new InstantiatingTemplate ctor
+      // that has a better message - right now we're just piggy-backing 
+      // off the "default template argument" error message.
+      InstantiatingTemplate Inst(*this, CallLoc, FD->getPrimaryTemplate(),
+                                 ArgList.getFlatArgumentList(),
+                                 ArgList.flat_size());
+
+      OwningExprResult Result = InstantiateExpr(UninstExpr, ArgList);
+      if (Result.isInvalid()) 
+        return ExprError();
+      
+      if (SetParamDefaultArgument(Param, move(Result), 
+                                  /*FIXME:EqualLoc*/
+                                  UninstExpr->getSourceRange().getBegin()))
+        return ExprError();
+    }
+    
+    Expr *DefaultExpr = Param->getDefaultArg();
+    
+    // If the default expression creates temporaries, we need to
+    // push them to the current stack of expression temporaries so they'll
+    // be properly destroyed.
+    if (CXXExprWithTemporaries *E 
+          = dyn_cast_or_null<CXXExprWithTemporaries>(DefaultExpr)) {
+      assert(!E->shouldDestroyTemporaries() && 
+             "Can't destroy temporaries in a default argument expr!");
+      for (unsigned I = 0, N = E->getNumTemporaries(); I != N; ++I)
+        ExprTemporaries.push_back(E->getTemporary(I));
+    }
+  }
+
+  // We already type-checked the argument, so we know it works.
+  return Owned(CXXDefaultArgExpr::Create(Context, Param));
+}
+
 /// ConvertArgumentsForCall - Converts the arguments specified in
 /// Args/NumArgs to the parameter types of the function FDecl with
 /// function prototype Proto. Call is the call expression itself, and
@@ -2493,60 +2544,16 @@
         return true;
     } else {
       ParmVarDecl *Param = FDecl->getParamDecl(i);
-      if (Param->hasUnparsedDefaultArg()) {
-        Diag (Call->getSourceRange().getBegin(),
-              diag::err_use_of_default_argument_to_function_declared_later) <<
-        FDecl << cast<CXXRecordDecl>(FDecl->getDeclContext())->getDeclName();
-        Diag(UnparsedDefaultArgLocs[Param], 
-              diag::note_default_argument_declared_here);
-      } else {
-        if (Param->hasUninstantiatedDefaultArg()) {
-          Expr *UninstExpr = Param->getUninstantiatedDefaultArg();
-
-          // Instantiate the expression.
-          const TemplateArgumentList &ArgList = 
-            getTemplateInstantiationArgs(FDecl);
-          
-          // FIXME: We should really make a new InstantiatingTemplate ctor
-          // that has a better message - right now we're just piggy-backing 
-          // off the "default template argument" error message.
-          InstantiatingTemplate Inst(*this, Call->getSourceRange().getBegin(),
-                                     FDecl->getPrimaryTemplate(),
-                                     ArgList.getFlatArgumentList(),
-                                     ArgList.flat_size());
-
-          OwningExprResult Result
-            = InstantiateExpr(UninstExpr, 
-                              getTemplateInstantiationArgs(FDecl));
-          if (Result.isInvalid()) 
-            return true;
-          
-          if (SetParamDefaultArgument(Param, move(Result), 
-                                      /*FIXME:EqualLoc*/
-                                      UninstExpr->getSourceRange().getBegin()))
-            return true;
-        }
-        
-        Expr *DefaultExpr = Param->getDefaultArg();
-        
-        // If the default expression creates temporaries, we need to
-        // push them to the current stack of expression temporaries so they'll
-        // be properly destroyed.
-        if (CXXExprWithTemporaries *E 
-              = dyn_cast_or_null<CXXExprWithTemporaries>(DefaultExpr)) {
-          assert(!E->shouldDestroyTemporaries() && 
-                 "Can't destroy temporaries in a default argument expr!");
-          for (unsigned I = 0, N = E->getNumTemporaries(); I != N; ++I)
-            ExprTemporaries.push_back(E->getTemporary(I));
-        }
-      }
-  
-      // We already type-checked the argument, so we know it works.
-      Arg = CXXDefaultArgExpr::Create(Context, Param);
+     
+      OwningExprResult ArgExpr = 
+        BuildCXXDefaultArgExpr(Call->getSourceRange().getBegin(),
+                               FDecl, Param);
+      if (ArgExpr.isInvalid())
+        return true;
+      
+      Arg = ArgExpr.takeAs<Expr>();
     }
     
-    QualType ArgType = Arg->getType();
-
     Call->setArg(i, Arg);
   }