[cfe-commits] r79448 - in /cfe/trunk: include/clang/Rewrite/Rewriter.h lib/Frontend/FixItRewriter.cpp lib/Frontend/RewriteBlocks.cpp lib/Frontend/RewriteMacros.cpp lib/Frontend/RewriteObjC.cpp lib/Rewrite/HTMLRewrite.cpp lib/Rewrite/Rewriter.cpp

Daniel Dunbar daniel at zuster.org
Wed Aug 19 13:37:10 PDT 2009


On Wed, Aug 19, 2009 at 12:10 PM, Daniel Dunbar<daniel at zuster.org> wrote:
> Author: ddunbar
> Date: Wed Aug 19 14:10:30 2009
> New Revision: 79448
>
> URL: http://llvm.org/viewvc/llvm-project?rev=79448&view=rev
> Log:
> Convert parts of Rewriter to StringRef based API.
>  - Please accept my sincere apologies for the gratuitous elimination of code
>   duplication, manual string length counting, unnecessary strlen calls, etc.

I didn't quite have the energy to take it on, but RewriteObjC.cpp
should take advantage of this cleanup as well. Switch the InsertText
and RewriteText methods to StringRef should make the code simpler and
shorter.

 - Daniel




More information about the cfe-commits mailing list