[cfe-commits] r78638 - in /cfe/trunk: lib/AST/RecordLayoutBuilder.cpp lib/CodeGen/CGCXX.cpp test/CodeGenCXX/virt.cpp

[Daniel Dunbar]

On Mon, Aug 10, 2009 at 9:03 PM, Mike Stump<mrs at apple.com> wrote:
> Hey, I've decided I want a change to FileCheck, I need to ensure that
> the group is together, nothing in between.  Can we change it to check
> the match line is from the line immediately following the last matched
> line, if the source for the matched line is immediately after the
> source for the previously matched line?
>
> // CHECK: 1
> // CHECK: 2
> // CHECK: 3
>
> // CHECK: 4
> // CHECK: 5
> // CHECK: 6
>
> would require 1 2 and 3 to be continuous in the output, and 4 5 and 6
> to be continuous.

Argyrios wanted a similar feature (me too), but I think this design is
too fragile (& annoying for other tests which don't care). What about
a "block begin" and "block end" syntax? Or an attributes argument to
the check lines, which is more extensible (for example to negative
tests).

// CHECK: 1
// CHECK [adjacent]: 2
// CHECK [adjacent]: 3

// CHECK [not]: foo bar

Although its not clear what "not" should mean given the line by line
style ("not" on any subsequent line, but doesn't change the current
input line, would be reasonable I think).

 - Daniel