[cfe-commits] r78188 - in /cfe/trunk: include/clang/Driver/Options.def lib/Driver/Tools.cpp

[Benjamin Kramer]

Eli Friedman writes:
> On Wed, Aug 5, 2009 at 5:12 AM, Benjamin Kramer<benny.kra-gM/Ye1E23mwN+BqQ9rBEUg at public.gmane.org> wrote:
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>> +++ cfe/trunk/lib/Driver/Tools.cpp Wed Aug  5 07:11:11 2009
>> @@ -309,7 +309,8 @@
>>   if (Args.hasArg(options::OPT_ftime_report))
>>     CmdArgs.push_back("--time-passes");
>>   // FIXME: Set --enable-unsafe-fp-math.
>> -  if (!Args.hasArg(options::OPT_fomit_frame_pointer))
>> +  if (Args.hasArg(options::OPT_fno_omit_frame_pointer) ||
>> +      !Args.hasArg(options::OPT_fomit_frame_pointer))
>>     CmdArgs.push_back("--disable-fp-elim");
>>   if (!Args.hasFlag(options::OPT_fzero_initialized_in_bss,
>>                     options::OPT_fno_zero_initialized_in_bss,
> 
> 
> Not quite right; this doesn't handle stuff like "clang
> -fno-omit-frame-pointer -fomit-frame-pointer" correctly.
> 
> -Eli

Thanks for the review. Fixed here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090803/020023.html