[cfe-commits] r77299 - in /cfe/trunk: include/clang/AST/Type.h lib/AST/Type.cpp

John McCall rjmccall at apple.com
Tue Jul 28 13:29:22 PDT 2009


Mike Stump wrote:
> On Jul 27, 2009, at 10:41 PM, John McCall wrote:
>> URL: http://llvm.org/viewvc/llvm-project?rev=77299&view=rev
>> Log:
>> Reimplement QualifierSet using a single word, as requested by dgregor.
>>
>> +  static const uint32_t AddressSpaceShift = 5;
>> +  static const unsigned MaxAddressSpace = ~0u >> AddressSpaceShift;
>
> It would be nice if we could document this in the end user 
> documentation.  No, I don't know if we have a spot for this.


We don't seem to have an "implementation-defined behavior and limits" 
section in the manual, but we should.  No, I don't want to be the one 
responsible for maintaining it, either. :)

The limit I implemented in the follow-up patch was 2^24, which we now 
enforce via diagnostics.

John.



More information about the cfe-commits mailing list