[cfe-commits] Patch for review : Unicode step 2
public at alisdairm.net
Mon Jul 13 23:32:10 PDT 2009
> -----Original Message-----
> From: Chris Lattner [mailto:clattner at apple.com]
> Sent: 12 July 2009 23:49
> To: AlisdairM
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [cfe-commits] Patch for review : Unicode step 2
> On Jul 11, 2009, at 11:49 AM, AlisdairM wrote:
> > Attached is my second candidate patch for Unicode support, which also
> > includes step 1.
> > This patch adds support for the new Unicode character types char16_t
> > and
> > char32_t, which naturally touches quite a few files - hence the size
> > of the
> > patch.
> > It does not yet support Unicode character or string literals,
> > although most
> > of the string literal logic is in place. This will be step 3,
> > although I
> > hope to incrementally commit phases 1 and 2 first <g>
> Looking good to me, thanks for breaking this down into incremental
> @@ -198,7 +198,9 @@
> QualType VoidTy;
> QualType BoolTy;
> QualType CharTy;
> - QualType WCharTy; // [C++ 3.9.1p5], integer type in C99.
> + QualType WCharTy; // [C++ 3.9.1p5], integer type in C99.
> + QualType Char16Ty; // [C++0x 3.9.1p5], integer type in C99.
> + QualType Char32Ty; // [C++0x 3.9.1p5], integer type in C99.
> Is the section number right? Do we even want to use numbers for C++
> or should we use the section names instead?
> Otherwise, the patch looks good to me!
Thanks, patch committed.
Yes, those paragraph numbers appear to be one of the few cases that did not change for C++0x!
More information about the cfe-commits