[cfe-commits] r74299 - in /cfe/trunk: lib/AST/ExprConstant.cpp test/Sema/ext_vector_components.c

Nate Begeman natebegeman at mac.com
Sat Jun 27 18:24:06 PDT 2009


On Jun 27, 2009, at 8:07 PM, Eli Friedman wrote:

> On Fri, Jun 26, 2009 at 11:22 AM, Nate Begeman<natebegeman at mac.com>  
> wrote:
>> -  return APValue();
>> +  if (Result.isInt() || Result.isFloat()) {
>> +    unsigned NumElts = E->getType()->getAsVectorType()- 
>> >getNumElements();
>> +    llvm::SmallVector<APValue, 4> Elts(NumElts, Result);
>> +    Result = APValue(&Elts[0], Elts.size());
>> +  }
>> +  return Result;
>>  }
>
> Is there a missing conversion from the scalar type of the result to
> the element type of the vector?

Not sure; empirically it seems to work as expected, but I'll write  
some explicit tests for edge cases and try it out.

Nate




More information about the cfe-commits mailing list