[cfe-commits] r73641 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/AST/TypeNodes.def lib/AST/ASTContext.cpp lib/AST/Type.cpp lib/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclAttr.cpp lib/Sema/SemaDec

[Eli Friedman]

On Wed, Jun 17, 2009 at 5:28 PM, Chris Lattner<clattner at apple.com> wrote:
> +  /// getDependentSizedExtVectorType - Returns a non-unique reference
> to
> +  /// the type for a dependently-sized vector of the specified element
> +  /// type. FIXME: We will need these to be uniqued, or at least
> +  /// comparable, at some point.
> +  QualType getDependentSizedExtVectorType(QualType VectorType,
> +                                          Expr *SizeExpr,
> +                                          SourceLocation AttrLoc);
>
> If this includes a Loc, uniquing will never reuse a type.  Is there
> really any reason to unique these?

I don't think so; the only reasons to unique types are to save memory
and to speed up tests for type identity, and neither of those seems
relevant here (it's a rare construct, and we can't actually do any
interesting comparisons between dependent types.)

-Eli