[cfe-commits] Small patch

Douglas Gregor dgregor at apple.com
Mon Jun 15 09:07:38 PDT 2009


On Jun 11, 2009, at 8:33 AM, Anis Ahmad wrote:

>
> While familiarizing myself with the code, I noticed a comment to fix  
> the handling of namespace aliases by ensuring no attributes were  
> specified for the namespace (as per the spec).  Unless I'm deeply  
> mistaken, it seemed like it could be handled by a simple refactor.

While this patch does fix the problem, the error message we get  
("expected '{'") isn't very good. I would prefer if we parse both the  
attribute and then the "=", but emit a diagnostic that states  
explicitly that attributes are not permitted on namespace aliases.  
That will give the user a much better understanding of what went wrong.

	- Doug



More information about the cfe-commits mailing list