[cfe-commits] r72715 - /cfe/trunk/lib/AST/ASTContext.cpp

[Fariborz Jahanian]

On Jun 2, 2009, at 11:38 AM, Eli Friedman wrote:

> On Tue, Jun 2, 2009 at 11:35 AM, Fariborz  
> Jahanian<fjahanian at apple.com> wrote:
>>
>> On Jun 2, 2009, at 10:32 AM, Eli Friedman wrote:
>>>>
>>>
>>> I don't think I really have any questions, it's just that the way  
>>> that
>>> the qualifier is allowed at any layer is simply weird.  The one  
>>> thing
>>> I've considered that might make it a bit cleaner is always pulling  
>>> the
>>> attribute out to the outermost array/pointer type, and always  
>>> pushing
>>
>> This is what gcc does.
>>>
>>> it back in on a dereference, which would make the whole thing  
>>> actually
>>> work consistently.  Currently, there's an issue that for the two
>>> lines:
>>>
>>> __weak id* x;
>>> id* __weak y;
>>>
>>> The generated code for *x and *y is different.
>>
>> For clang it is. gcc does the above and generates the same code.
>
> Oh, so this is a bug in the clang implementation.  Want me to file a  
> bug?
Please.

- Fariborz

>
>
> -Eli