[cfe-commits] r72733 - in /cfe/trunk: lib/AST/ASTContext.cpp test/SemaObjC/objc2-merge-gc-attribue-decl.m

Fariborz Jahanian fjahanian at apple.com
Tue Jun 2 11:43:07 PDT 2009


On Jun 2, 2009, at 11:36 AM, Eli Friedman wrote:

> On Tue, Jun 2, 2009 at 11:32 AM, Fariborz  
> Jahanian<fjahanian at apple.com> wrote:
>> +      // __weak attribute must appear on both declarations.
>> +      // FIXME. __strong attribue is redundant if other decl is an  
>> objective-c
>> +      // object pointer (or decorated with __strong attribute). We  
>> can't issue
>> +      // diagnostic on __strong mismatch becuase 'id' may not be
>> +      // available but only with its canonical type at this point.  
>> Will
>> +      // visit this when 'id' becomes a concrete type.
>
> In other places, we treat any struct objc_object* as "id"; can we do  
> that here?

I wasn't aware of this. If this is the case, then I will add the  
needed diagnostics. I will ask Steve.

- Fariborz

>
>
> -Eli




More information about the cfe-commits mailing list