[cfe-commits] r71979 - /cfe/trunk/lib/Sema/SemaExpr.cpp

[Anders Carlsson]

Author: andersca
Date: Sun May 17 11:28:18 2009
New Revision: 71979

URL: http://llvm.org/viewvc/llvm-project?rev=71979&view=rev
Log:
Add FIXME about not using MemberExpr nodes when the base type is a dependent type.

Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=71979&r1=71978&r2=71979&view=diff

==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Sun May 17 11:28:18 2009
@@ -2023,6 +2023,8 @@
   // must have pointer type, and the accessed type is the pointee.
   if (OpKind == tok::arrow) {
     if (BaseType->isDependentType())
+      // FIXME: This should not return a MemberExpr AST node, but a more 
+      // specialized one.
       return Owned(new (Context) MemberExpr(BaseExpr, true, 0,
                                             MemberLoc, Context.DependentTy));
     else if (const PointerType *PT = BaseType->getAsPointerType())
@@ -2048,6 +2050,8 @@
 
       if (!PT || (getLangOptions().ObjC1 && 
                   !PT->getPointeeType()->isRecordType()))
+        // FIXME: This should not return a MemberExpr AST node, but a more 
+        // specialized one.
         return Owned(new (Context) MemberExpr(BaseExpr, false, 0,
                                               MemberLoc, Context.DependentTy));
     }