[cfe-commits] [patch] Fixed for function specifiers

Eli Friedman eli.friedman at gmail.com
Wed May 13 13:01:24 PDT 2009


On Wed, May 13, 2009 at 11:38 AM, Anders Johnsen <skabet at gmail.com> wrote:
> This is some small fixes for function specifiers, including a test case.

The isExplicitOkay changes look generally okay, except that I'm not
sure about changing the text of the diagnostic: it's stating something
that isn't actually true in C++0x.

I don't think the change to the signature of
DiagnoseFunctionSpecifiers is a good idea: I never actually got around
to implementing it, but it makes it impossible to fix the FIXME at the
top of the function.  It may seem like code duplication, but I think
I'd prefer to use separate diagnostics for the
ParsedFreeStandingDeclSpec case.

-Eli



More information about the cfe-commits mailing list