[cfe-commits] r71145 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/block-misc.c test/SemaObjC/conditional-expr-2.m

Mike Stump mrs at apple.com
Thu May 7 14:14:09 PDT 2009

On May 7, 2009, at 1:49 PM, Eli Friedman wrote:
> The issue isn't that the condition is unreadable, but that we'd have
> to add a bunch more conditions to catch all the cases.  For example,
> we don't want to warn about "a<a" when a is complex or a struct, or
> for '1i=="asdf"', etc.  Hence the suggestion to reorganize the code so
> that if we print any error, we skip the warning.

Ah...  I now see your point.  Yeah, hard to disagree with.  I'll sleep  
on it and see if I can come up with something that I like better and  
doesn't do any violence to the code.

More information about the cfe-commits mailing list