[cfe-commits] r70404 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

[Daniel Dunbar]

Hi Fariborz,
Can you explain this change?

The function type being constructed has known arguments (it is filled in
from the actual arguments), so this change doesn't make much sense to me.

 - Daniel

On Wed, Apr 29, 2009 at 12:14 PM, Fariborz Jahanian <fjahanian at apple.com>wrote:

> Author: fjahanian
> Date: Wed Apr 29 14:14:43 2009
> New Revision: 70404
>
> URL: http://llvm.org/viewvc/llvm-project?rev=70404&view=rev
> Log:
> Type of msgSend message dispatch API is a vararg.
>
>
> Modified:
>    cfe/trunk/lib/CodeGen/CGObjCMac.cpp
>
> Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=70404&r1=70403&r2=70404&view=diff
>
>
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGObjCMac.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGObjCMac.cpp Wed Apr 29 14:14:43 2009
> @@ -1413,7 +1413,9 @@
>
>   CodeGenTypes &Types = CGM.getTypes();
>   const CGFunctionInfo &FnInfo = Types.getFunctionInfo(ResultType,
> ActualArgs);
> -  const llvm::FunctionType *FTy = Types.GetFunctionType(FnInfo, false);
> +  // Type is a vararg. In 32bit code gen. it is ignored. In 64bit it is
> +  // looked at.
> +  const llvm::FunctionType *FTy = Types.GetFunctionType(FnInfo, true);
>
>   llvm::Constant *Fn;
>   if (CGM.ReturnTypeUsesSret(FnInfo)) {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090429/57a0cc96/attachment.html>