[cfe-commits] r69192 - in /cfe/trunk/include/clang/Basic: Diagnostic.td DiagnosticCommonKinds.td DiagnosticLexKinds.td DiagnosticSemaKinds.td

Chris Lattner clattner at apple.com
Wed Apr 15 12:54:30 PDT 2009


On Apr 15, 2009, at 12:21 PM, Sebastian Redl wrote:

> Chris Lattner wrote:
>> Author: lattner
>> Date: Wed Apr 15 13:08:55 2009
>> New Revision: 69192
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=69192&view=rev
>> Log:
>> annotate diagnostics with which groups they belong to.  Each
>> diagnostic can belong to at most one group.
>
> Hmm ... this is not like we planned it. I don't know if we have any  
> real
> use cases for having a diag in multiple, independent groups. I thought
> it would be nice if we wanted to, say, group warnings once by topical
> area (e.g. -Winheritance, -Wtemplates, -Wobsolete, or -Weffective-cxx,
> -Wcxx-gotchas, -Wcxx-coding-standards :-) ) and perhaps a different  
> way
> by sensitivity/likelihood of false positives (similar to what MSVC's
> warning levels do).

In order to support -fdiagnostics-show-option, we need a 1-(zero or  
one) mapping between a diagnostic and the minimal option that controls  
it.  After this works, I'll add group inheritance, so that -Wall can  
turn on a number of groups, etc.  This should handle -Wtemplates etc.

-Chris



More information about the cfe-commits mailing list