[cfe-commits] r67221 - /cfe/trunk/include/clang/Rewrite/HTMLRewrite.h

[Daniel Dunbar]

On Wed, Mar 18, 2009 at 9:59 PM, Ted Kremenek <kremenek at apple.com> wrote:

> It turned out just to be an optimization.  It does less work, not more.  Do
> you have a suggestion of what would be a good test case for this?
>

No, I didn't really look at the issue, it just seemed like a lengthy radar
discussion for no test case. :)

 - Daniel

Testing this has more to do with the browser behavior than the emitted HTML.
>
>
> On Mar 18, 2009, at 1:04 PM, Daniel Dunbar wrote:
>
> Test case for this isn't out of the question?
>
>  - Daniel
>
> On Wed, Mar 18, 2009 at 11:47 AM, Ted Kremenek <kremenek at apple.com> wrote:
>
>> Author: kremenek
>> Date: Wed Mar 18 13:47:46 2009
>> New Revision: 67221
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=67221&view=rev
>> Log:
>> HTML rewriter: Don't replace tabs with spaces by default.
>>
>> Modified:
>>    cfe/trunk/include/clang/Rewrite/HTMLRewrite.h
>>
>> Modified: cfe/trunk/include/clang/Rewrite/HTMLRewrite.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Rewrite/HTMLRewrite.h?rev=67221&r1=67220&r2=67221&view=diff
>>
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Rewrite/HTMLRewrite.h (original)
>> +++ cfe/trunk/include/clang/Rewrite/HTMLRewrite.h Wed Mar 18 13:47:46 2009
>> @@ -52,14 +52,14 @@
>>   /// EscapeText - HTMLize a specified file so that special characters are
>>   /// are translated so that they are not interpreted as HTML tags.
>>   void EscapeText(Rewriter& R, FileID FID,
>> -                  bool EscapeSpaces = false, bool ReplacesTabs = true);
>> +                  bool EscapeSpaces = false, bool ReplaceTabs = false);
>>
>>   /// EscapeText - HTMLized the provided string so that special characters
>>   ///  in 's' are not interpreted as HTML tags.  Unlike the version of
>>   ///  EscapeText that rewrites a file, this version by default replaces
>> tabs
>>   ///  with spaces.
>>   std::string EscapeText(const std::string& s,
>> -                         bool EscapeSpaces = false, bool ReplaceTabs =
>> true);
>> +                         bool EscapeSpaces = false, bool ReplaceTabs =
>> false);
>>
>>   void AddLineNumbers(Rewriter& R, FileID FID);
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20090318/f8a1488c/attachment.html>