[cfe-commits] r67161 - /cfe/trunk/lib/Driver/Action.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Tue Mar 17 22:02:22 2009
New Revision: 67161

URL: http://llvm.org/viewvc/llvm-project?rev=67161&view=rev
Log:
Driver: I was too hasty in free'ing Actions, we sometimes share
Actions so a simple tree traversal isn't quite good enough. Leaving a
FIXME for now.

Modified:
    cfe/trunk/lib/Driver/Action.cpp

Modified: cfe/trunk/lib/Driver/Action.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Action.cpp?rev=67161&r1=67160&r2=67161&view=diff

==============================================================================
--- cfe/trunk/lib/Driver/Action.cpp (original)
+++ cfe/trunk/lib/Driver/Action.cpp Tue Mar 17 22:02:22 2009
@@ -13,9 +13,8 @@
 using namespace clang::driver;
 
 Action::~Action() {
-  // Free the inputs.
-  for (iterator it = begin(), ie = end(); it != ie; ++it)
-    delete *it;  
+  // FIXME: Free the inputs. The problem is that BindArchAction shares
+  // inputs; so we can't just walk the inputs.
 }
 
 const char *Action::getClassName(ActionClass AC) {