[cfe-commits] r66555 - in /cfe/trunk/lib: AST/APValue.cpp AST/StmtPrinter.cpp Analysis/SVals.cpp Basic/SourceLocation.cpp CodeGen/CGCall.cpp Driver/Arg.cpp Driver/Driver.cpp Driver/Option.cpp

[Daniel Dunbar]

On Thu, Mar 12, 2009 at 2:47 PM, Chris Lattner <clattner at apple.com> wrote:
> On Mar 10, 2009, at 11:00 AM, Daniel Dunbar wrote:
>> Author: ddunbar
>> Date: Tue Mar 10 13:00:19 2009
>> New Revision: 66555
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=66555&view=rev
>> Log:
>> Remove some now-unneeded calls to llvm::errs().flush().
>
> Are you sure these are unneeded?  Your change just causes calls to OS.write
> to be unbuffered for stderr, not operator<<(char) and others.

They *should* be unneeded. I missed that raw_ostream wasn't going
through write() for all access to the buffer; I will fix them to flush
on unbuffered as well. I know, I know, it hurts, but so does not
getting reasonable debugging output.

 - Daniel