[cfe-commits] r66518 - in /cfe/trunk/lib/Frontend: HTMLDiagnostics.cpp PlistDiagnostics.cpp

Ted Kremenek kremenek at apple.com
Mon Mar 9 19:49:29 PDT 2009


Author: kremenek
Date: Mon Mar  9 21:49:29 2009
New Revision: 66518

URL: http://llvm.org/viewvc/llvm-project?rev=66518&view=rev
Log:
Handle "Macro" PathDiagnosticPiece kind when getting string identifier.

Modified:
    cfe/trunk/lib/Frontend/HTMLDiagnostics.cpp
    cfe/trunk/lib/Frontend/PlistDiagnostics.cpp

Modified: cfe/trunk/lib/Frontend/HTMLDiagnostics.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/HTMLDiagnostics.cpp?rev=66518&r1=66517&r2=66518&view=diff

==============================================================================
--- cfe/trunk/lib/Frontend/HTMLDiagnostics.cpp (original)
+++ cfe/trunk/lib/Frontend/HTMLDiagnostics.cpp Mon Mar  9 21:49:29 2009
@@ -159,8 +159,7 @@
   // Create a new rewriter to generate HTML.
   Rewriter R(SMgr);
   
-  // Process the path.
-  
+  // Process the path.  
   unsigned n = D.size();
   unsigned max = n;
   
@@ -376,7 +375,7 @@
       switch (*I) {
         default:
           ++cnt;
-          continue;          
+          continue;    
         case ' ':
         case '\t':
         case '\n':
@@ -410,9 +409,9 @@
     // Now generate the message bubble. 
     const char *Kind = 0;
     switch (P.getKind()) {
-      default: break;
       case PathDiagnosticPiece::Event:  Kind = "Event"; break;
       case PathDiagnosticPiece::ControlFlow: Kind = "Control"; break;
+      case PathDiagnosticPiece::Macro: Kind = "Macro"; break;
     }
     
     std::string sbuf;

Modified: cfe/trunk/lib/Frontend/PlistDiagnostics.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/PlistDiagnostics.cpp?rev=66518&r1=66517&r2=66518&view=diff

==============================================================================
--- cfe/trunk/lib/Frontend/PlistDiagnostics.cpp (original)
+++ cfe/trunk/lib/Frontend/PlistDiagnostics.cpp Mon Mar  9 21:49:29 2009
@@ -136,10 +136,14 @@
 #endif
   // Output the PathDiagnosticPiece::Kind.
   Indent(o, indent) << "<key>kind</key>\n";
-  Indent(o, indent) << "<string>"
-    << (P.getKind() == PathDiagnosticPiece::Event 
-        ? "Event" : "ControlFlow")
-    << "</string>\n";
+  Indent(o, indent) << "<string>";
+  
+  switch (P.getKind()) {
+    case PathDiagnosticPiece::Event: o << "Event"; break;
+    case PathDiagnosticPiece::ControlFlow: o << "ControlFlow"; break;
+    case PathDiagnosticPiece::Macro: o << "Macro"; break;
+  }
+  o << "</string>\n";
   
   
   // Finish up.





More information about the cfe-commits mailing list