[cfe-commits] r66321 - in /cfe/trunk/lib/CodeGen: CGExprScalar.cpp CGObjCMac.cpp

Fariborz Jahanian fjahanian at apple.com
Sat Mar 7 09:54:23 PST 2009


On Mar 6, 2009, at 7:57 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Fri Mar  6 21:57:15 2009
> New Revision: 66321
>
> URL: http://llvm.org/viewvc/llvm-project?rev=66321&view=rev
> Log:
> Back out the patch in r66302, and re-fix it properly.  We assume for
> performance that the type of the returned llvm::Value for an  
> expression
> matches the converted type of the clang::Expr; mismatches will cause  
> all
> sorts of errors and silent miscompilations.
>
>
> Modified:
>    cfe/trunk/lib/CodeGen/CGExprScalar.cpp
>    cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Thanks. Yes, this is the right way to go.

- Fariborz

>



More information about the cfe-commits mailing list