[cfe-commits] r66323 - /cfe/trunk/lib/CodeGen/CGBlocks.cpp

Mike Stump mrs at apple.com
Fri Mar 6 22:16:52 PST 2009

Author: mrs
Date: Sat Mar  7 00:16:52 2009
New Revision: 66323

URL: http://llvm.org/viewvc/llvm-project?rev=66323&view=rev
Remove last FIXME for block literal codegen that I know about and turn
on all the new code by default.  There is still plenty of testing to
do and issues I'm sure need resolving.  Let me know if you find


Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBlocks.cpp?rev=66323&r1=66322&r2=66323&view=diff

--- cfe/trunk/lib/CodeGen/CGBlocks.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGBlocks.cpp Sat Mar  7 00:16:52 2009
@@ -31,7 +31,7 @@
                              "even though the code isn't done yet"),
               llvm::cl::ValueDisallowed, llvm::cl::AllowInverse,
-              llvm::cl::init(false));
+              llvm::cl::init(true));
 llvm::Constant *CodeGenFunction::
 BuildDescriptorBlockDecl(uint64_t Size, const llvm::StructType* Ty,
@@ -479,7 +479,6 @@
   const llvm::Type *Ty;
   Ty = CGM.getTypes().ConvertType(E->getDecl()->getType());
-  // FIXME: add support for copy/dispose helpers.
   if (!Enable__block && E->isByRef())
     ErrorUnsupported(E, "__block variable in block literal");
   else if (!Enable__block && E->getType()->isBlockPointerType())

More information about the cfe-commits mailing list