[cfe-commits] r65969 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.def lib/Sema/SemaStmt.cpp test/SemaObjC/catch-stmt.m

Eli Friedman eli.friedman at gmail.com
Tue Mar 3 15:00:04 PST 2009

On Tue, Mar 3, 2009 at 1:16 PM, Steve Naroff <snaroff at apple.com> wrote:
> +    if (PVD->getType()->isObjCQualifiedIdType())
> +      return StmtError(Diag(PVD->getLocation(),
> +                       diag::warn_ignoring_qualifiers_on_catch_parm));
> +  }

Either it's a warning or it's an error... if it's a warning, you have
to recover, and if it's an error, you have to mark it as such.  The
alternative is unintuitive errors or miscompilations when code that
expects a valid AST gets an invalid one.


More information about the cfe-commits mailing list