[cfe-commits] r65262 - /cfe/trunk/lib/CodeGen/CGCall.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Sat Feb 21 22:16:10 2009
New Revision: 65262

URL: http://llvm.org/viewvc/llvm-project?rev=65262&view=rev
Log:
x86_64 ABI: Classify <1 x i64> as INTEGER (match gcc not llvm-gcc).

Also, make sure to pass <1 x i64> as i64 (not <1 x i64>, which doesn't
quite work yet in the backend).

Modified:
    cfe/trunk/lib/CodeGen/CGCall.cpp

Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=65262&r1=65261&r2=65262&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGCall.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCall.cpp Sat Feb 21 22:16:10 2009
@@ -524,11 +524,15 @@
   } else if (const VectorType *VT = Ty->getAsVectorType()) {
     uint64_t Size = Context.getTypeSize(VT);
     if (Size == 64) {
-      // gcc passes <1 x double> in memory.
-      if (VT->getElementType() == Context.DoubleTy)
+      // gcc passes <1 x double> in memory. :(
+      if (VT->getElementType()->isSpecificBuiltinType(BuiltinType::Double))
         return;
-
-      Current = SSE;
+      
+      // gcc passes <1 x long long> as INTEGER.
+      if (VT->getElementType()->isSpecificBuiltinType(BuiltinType::LongLong))
+        Current = Integer;
+      else
+        Current = SSE;
 
       // If this type crosses an eightbyte boundary, it should be
       // split.
@@ -542,7 +546,7 @@
     QualType ET = Context.getCanonicalType(CT->getElementType());
     
     uint64_t Size = Context.getTypeSize(Ty);
-    if (ET->isIntegerType()) {
+    if (ET->isIntegralType()) {
       if (Size <= 64)
         Current = Integer;
       else if (Size <= 128)
@@ -688,8 +692,9 @@
   if (CoerceTo == llvm::Type::Int64Ty) {
     // Integer and pointer types will end up in a general purpose
     // register.
-    if (Ty->isIntegerType() || Ty->isPointerType())
+    if (Ty->isIntegralType() || Ty->isPointerType())
       return ABIArgInfo::getDirect();
+
   } else if (CoerceTo == llvm::Type::DoubleTy) {
     // FIXME: It would probably be better to make CGFunctionInfo only
     // map using canonical types than to canonize here.
@@ -698,6 +703,7 @@
     // Float and double end up in a single SSE reg.
     if (CTy == Context.FloatTy || CTy == Context.DoubleTy)
       return ABIArgInfo::getDirect();
+
   }
 
   return ABIArgInfo::getCoerce(CoerceTo);