[cfe-commits] Patch for review

[Chris Lattner]

On Feb 17, 2009, at 11:31 AM, Ted Kremenek wrote:

>
> On Feb 17, 2009, at 11:21 AM, Chris Lattner wrote:
>
>>
>> On Feb 17, 2009, at 2:23 AM, Ben Laurie wrote:
>>
>>> Don't include alloca.h if it doesn't exist.
>>
>> Ideally the analyzer test cases wouldn't use the system assert.  Why
>> not have an analyzer-specific assert.h that "is defined right"?
>>
>> -Chris
>
> I disagree.  I think it is actually very useful to detect when the  
> test fails based on the system-specific definition of 'assert.'   
> This particular test failure told us (among other things) that  
> '__assert' wasn't being recognized as a panic function.

Alright.

-Chris