[cfe-commits] TextDiagnosticBuffer doesn't handle fatal errors

Ted Kremenek kremenek at apple.com
Tue Feb 17 08:48:20 PST 2009


This looks fine to me.  I think the distinction between fatal errors  
and errors are that fatal errors terminates all processing of a  
translation unit.  Please apply.

On Feb 17, 2009, at 2:03 AM, Ben Laurie wrote:

> Proposed patch (doesn't seem worth creating a new holder for fatal
> errors to me, but happy to do so if people disagree):
>
> Index: lib/Driver/TextDiagnosticBuffer.cpp
> ===================================================================
> --- lib/Driver/TextDiagnosticBuffer.cpp (revision 64650)
> +++ lib/Driver/TextDiagnosticBuffer.cpp (working copy)
> @@ -32,6 +32,7 @@
>     Warnings.push_back(std::make_pair(Info.getLocation(), Str));
>     break;
>   case Diagnostic::Error:
> +  case Diagnostic::Fatal:
>     Errors.push_back(std::make_pair(Info.getLocation(), Str));
>     break;
>   }
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list