[cfe-commits] r64416 - /cfe/trunk/tools/ccc/ccclib/Tools.py

[Chris Lattner]

>> I don't understand the objection to the #ifndef.  The #ifndef  
>> doesn't *hard
>> code* the value to a specific state, it just changes the default.   
>> You can
>> still use -disable-free=1 or -disable-free=0 to get either state in  
>> either
>> build.
>
> My objection is that I frequently build Debug/Release/Release-Asserts
> builds out of the same tree (this is why the gcc equivalent is not the
> same as NDEBUG Mike). It is confusing to have otherwise similar
> binaries change behavior.
>
> If we were to tie to NDEBUG, I would at least argue that we should do
> it in the driver so that the output of -### and -v always shows
> exactly how clang is being run.

Ok, well the driver could always pass a value for -disable-free... but  
that wouldn't fix the original problem of *wanting* different behavior  
in production vs debug builds.

-Chris