[cfe-commits] r64416 - /cfe/trunk/tools/ccc/ccclib/Tools.py

[Chris Lattner]

On Feb 12, 2009, at 4:31 PM, Douglas Gregor wrote:

>
> On Feb 12, 2009, at 4:29 PM, Daniel Dunbar wrote:
>
>> Author: ddunbar
>> Date: Thu Feb 12 18:29:22 2009
>> New Revision: 64416
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=64416&view=rev
>> Log:
>> Always pass -disable-free to clang when compiling.
>
> This makes me sad. I found an icky ownership problem a few days ago
> that I would have missed completely if we always passed "-disable-
> free". Since we're moving toward using the driver for *everything*, it
> really seems like we want -disable-free in Release-Asserts builds but
> not in Debug builds.

How about just doing something like:

static llvm::cl::opt<bool>
DisableFree("disable-free",
            llvm::cl::desc("Disable freeing of memory on exit"),
#ifndef NDEBUG
            llvm::cl::init(true)
#else
            llvm::cl::init(false)
#endif
);

?

-Chris