[cfe-commits] r62909 - in /cfe/trunk: lib/Analysis/MemRegion.cpp test/Analysis/exercise-ps.c

[Ted Kremenek]

Author: kremenek
Date: Sat Jan 24 00:11:36 2009
New Revision: 62909

URL: http://llvm.org/viewvc/llvm-project?rev=62909&view=rev
Log:
Fix crash ElementRegion::getRValueType() when the RvalueType of the ArrayRegion is a typedef and not (directly) a pointer.

Modified:
    cfe/trunk/lib/Analysis/MemRegion.cpp
    cfe/trunk/test/Analysis/exercise-ps.c

Modified: cfe/trunk/lib/Analysis/MemRegion.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/MemRegion.cpp?rev=62909&r1=62908&r2=62909&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/MemRegion.cpp (original)
+++ cfe/trunk/lib/Analysis/MemRegion.cpp Sat Jan 24 00:11:36 2009
@@ -108,17 +108,14 @@
 }
 
 QualType ElementRegion::getRValueType(ASTContext& C) const {
-  QualType T = getArrayRegion()->getRValueType(C);
+  // Strip off typedefs from the ArrayRegion's RvalueType.
+  QualType T = getArrayRegion()->getRValueType(C)->getDesugaredType();
 
-  if (isa<ArrayType>(T.getTypePtr())) {
-    ArrayType* AT = cast<ArrayType>(T.getTypePtr());
+  if (ArrayType* AT = dyn_cast<ArrayType>(T.getTypePtr()))
     return AT->getElementType();
-  }
-  else {
-    PointerType* PtrT = cast<PointerType>(T.getTypePtr());
-    QualType PTy = PtrT->getPointeeType();
-    return C.getCanonicalType(PTy);
-  }
+
+  PointerType* PtrT = cast<PointerType>(T.getTypePtr());
+  return C.getCanonicalType(PtrT->getPointeeType());
 }
 
 //===----------------------------------------------------------------------===//

Modified: cfe/trunk/test/Analysis/exercise-ps.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/exercise-ps.c?rev=62909&r1=62908&r2=62909&view=diff

==============================================================================
--- cfe/trunk/test/Analysis/exercise-ps.c (original)
+++ cfe/trunk/test/Analysis/exercise-ps.c Sat Jan 24 00:11:36 2009
@@ -2,7 +2,8 @@
 // RUN: clang -analyze -checker-cfref -analyzer-store-basic -verify %s &&
 // RUN: clang -analyze -checker-cfref -analyzer-store-region -verify %s
 //
-// Just exercise the analyzer (no assertions).
+// Just exercise the analyzer on code that has at one point caused issues
+// (i.e., no assertions or crashes).
 
 
 static const char * f1(const char *x, char *y) {
@@ -10,3 +11,14 @@
     *y++ = *x++;
   }
 }
+
+// This following case checks that we properly handle typedefs when getting
+// the RvalueType of an ElementRegion.
+typedef struct F12_struct {} F12_typedef;
+typedef void* void_typedef;
+void_typedef f2_helper();
+static void f2(void *buf) {
+  F12_typedef* x;
+  x = f2_helper();
+  memcpy((&x[1]), (buf), 1);
+}