[cfe-commits] r62846 - /cfe/trunk/lib/Analysis/RegionStore.cpp

Zhongxing Xu xuzhongxing at gmail.com
Fri Jan 23 02:42:24 PST 2009


Author: zhongxingxu
Date: Fri Jan 23 04:42:17 2009
New Revision: 62846

URL: http://llvm.org/viewvc/llvm-project?rev=62846&view=rev
Log:
Now this comment should be resolved. See the comments for the KillSet.

Modified:
    cfe/trunk/lib/Analysis/RegionStore.cpp

Modified: cfe/trunk/lib/Analysis/RegionStore.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/RegionStore.cpp?rev=62846&r1=62845&r2=62846&view=diff

==============================================================================
--- cfe/trunk/lib/Analysis/RegionStore.cpp (original)
+++ cfe/trunk/lib/Analysis/RegionStore.cpp Fri Jan 23 04:42:17 2009
@@ -572,12 +572,6 @@
 
   GRStateRef state(St, StateMgr);
   
-  // FIXME: Do we even need a killset?  If 'Unknown' is explicitly
-  //  bound to to a region won't this be enough?  (that's basically
-  //  what a killset is).  RemoveDeadBindings should only remove
-  //  bindings that are no longer accessible, which means that won't
-  //  ever be read.
-
   // Check if the region is in killset.
   if (state.contains<RegionKills>(R))
     return UnknownVal();





More information about the cfe-commits mailing list