[cfe-commits] r62347 - /cfe/trunk/lib/Lex/PPDirectives.cpp

[Daniel Dunbar]

Agreed. It might be worth looking for other "relatively expensive"
checks. Maybe the static analyzer can do it!? :)

 - Daniel

On Fri, Jan 16, 2009 at 1:02 PM, Chris Lattner <sabre at nondot.org> wrote:
>
> On Jan 16, 2009, at 12:04 PM, Daniel Dunbar wrote:
>
>> Nice; one question though: I suspect this is not the only place we are
>> doing such things. Did you audit Sema at all for this kind of stuff?
>>
>> We have -suppress-system-warnings=false to show when we are emitting
>> diagnostics that get ignored, but there is no way to see places where
>> we do needless computation without manual inspection...
>
> No I didn't.  Unless a check is relatively expensive (like isIdenticalTo) I
> strongly prefer  not to litter code with this sort of optimization.
>
> -Chris
>