[cfe-commits] r62255 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/Sema/SemaExpr.cpp test/Sema/cast-to-union.c

[Chris Lattner]

On Jan 14, 2009, at 8:51 PM, Seo Sanghyeon wrote:

> Author: sanxiyn
> Date: Wed Jan 14 22:51:39 2009
> New Revision: 62255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=62255&view=rev
> Log:
> PR2746: Implement GCC cast to union extension

Very nice Seo!

> +DIAG(err_typecheck_cast_to_union_no_type, ERROR,
> +     "cast to union type from type %0 not present in union")

This diagnostic will get triggered when you cast from "random type" to  
"a union".  Because the user probably didn't *mean* to use the "cast  
to union" extension, and we don't really want to advertise its  
existence, maybe just using err_typecheck_cond_expect_scalar in this  
case would be better?

Also, does this include codegen support?  If not, can you please file  
a bugzilla requesting it?  Thanks,

-Chris