[cfe-commits] [PATCH] Fixes for pre-processor printing

[Chris Lattner]

On Jan 10, 2009, at 6:57 AM, Dan Villiom Podlaski Christiansen wrote:

> Hi,
>
> Attached below is a small patch against ‘Driver/ 
> PrintPreprocessedOutput.cpp’ which relaxes the rules for inserting  
> spaces in printed output a bit. Before this change, ‘clang -E’ was  
> unusable for processing the Makefiles used for building GNU Emacs.  
> I'm no C expert, but I believe that rules were too strict, and that  
> the change is safe.

This patch isn't correct, it causes 4 testsuite regressions.  For  
example, test/Preprocessor//output_paste_avoid.c starts incorrectly  
outputting "...", for three periods.  However, your idea of not  
avoiding pasting when C++ or digraphs are disabled seems reasonable  
enough.  I did this patch:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090105/010745.html

If there is a specific case that emacs' makefile needs, please give an  
example.

-Chris