[cfe-commits] r61090 - in /cfe/trunk: include/clang/Basic/DiagnosticKinds.def lib/Sema/SemaDeclObjC.cpp test/SemaObjC/property-typecheck-2.m

[Chris Lattner]

On Dec 17, 2008, at 9:22 AM, Fariborz Jahanian wrote:
>> Can this test be merged into other files?  I'd prefer to not have  
>> one file for each specific issue, rather have one file for each  
>> class of language construct.  maybe the property-typecheck cases  
>> can all be in one test file?
>
> I would like to keep the test cases per feature. This makes  
> regression checking a lot easier (a test failure will tell  which  
> feature it failed).
> I have a concern about putting every new ObjC feature test in the  
> same file. This will make diagnosis of a regression very hard. Are
> you suggesting that all ObjC sema checking goes into one single file?

I'm not suggesting that every objc sema check goes in the same file,  
just that we have slightly more granular tests, e.g. one for a  
particular piece of properties.  Typically these tests are all  
specific to a single function, so they can be extracted out if a  
failure happens.

-Chris