[cfe-commits] r61099 - in /cfe/trunk/lib/Sema: SemaDeclObjC.cpp SemaExprObjC.cpp

[Fariborz Jahanian]

Your changes do not change the semantics of the code. So, unless tests  
break,
they should be OK.

- Fariborz

On Dec 16, 2008, at 12:15 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Tue Dec 16 14:15:50 2008
> New Revision: 61099
>
> URL: http://llvm.org/viewvc/llvm-project?rev=61099&view=rev
> Log:
> Silence a couple more operator precedence warnings; this shouldn't
> change the semantics.  Please correct this if the precedence was
> actually supposed to be something different.
>
>
> Modified:
>    cfe/trunk/lib/Sema/SemaDeclObjC.cpp
>    cfe/trunk/lib/Sema/SemaExprObjC.cpp
>
> Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclObjC.cpp?rev=61099&r1=61098&r2=61099&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- cfe/trunk/lib/Sema/SemaDeclObjC.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaDeclObjC.cpp Tue Dec 16 14:15:50 2008
> @@ -1052,8 +1052,8 @@
>       const ObjCMethodDecl *&PrevMethod = InsMap[Method- 
> >getSelector()];
>       bool match = PrevMethod ? MatchTwoMethodDeclarations(Method,  
> PrevMethod)
>                               : false;
> -      if (isInterfaceDeclKind && PrevMethod && !match
> -          || checkIdenticalMethods && match) {
> +      if ((isInterfaceDeclKind && PrevMethod && !match)
> +          || (checkIdenticalMethods && match)) {
>           Diag(Method->getLocation(), diag::err_duplicate_method_decl)
>             << Method->getDeclName();
>           Diag(PrevMethod->getLocation(),  
> diag::note_previous_declaration);
> @@ -1069,8 +1069,8 @@
>       const ObjCMethodDecl *&PrevMethod = ClsMap[Method- 
> >getSelector()];
>       bool match = PrevMethod ? MatchTwoMethodDeclarations(Method,  
> PrevMethod)
>                               : false;
> -      if (isInterfaceDeclKind && PrevMethod && !match
> -          || checkIdenticalMethods && match) {
> +      if ((isInterfaceDeclKind && PrevMethod && !match)
> +          || (checkIdenticalMethods && match)) {
>         Diag(Method->getLocation(), diag::err_duplicate_method_decl)
>           << Method->getDeclName();
>         Diag(PrevMethod->getLocation(),  
> diag::note_previous_declaration);
>
> Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprObjC.cpp?rev=61099&r1=61098&r2=61099&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- cfe/trunk/lib/Sema/SemaExprObjC.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaExprObjC.cpp Tue Dec 16 14:15:50 2008
> @@ -538,7 +538,7 @@
>       for (; RHSProtoI != RHSProtoE; ++RHSProtoI) {
>         ObjCProtocolDecl *rhsProto = *RHSProtoI;
>         if (ProtocolCompatibleWithProtocol(lhsProto, rhsProto) ||
> -            compare && ProtocolCompatibleWithProtocol(rhsProto,  
> lhsProto)) {
> +            (compare && ProtocolCompatibleWithProtocol(rhsProto,  
> lhsProto))) {
>           match = true;
>           break;
>         }
> @@ -583,7 +583,7 @@
>       for (unsigned j = 0; j < rhsQID->getNumProtocols(); j++) {
>         ObjCProtocolDecl *rhsProto = rhsQID->getProtocols(j);
>         if (ProtocolCompatibleWithProtocol(lhsProto, rhsProto) ||
> -            compare && ProtocolCompatibleWithProtocol(rhsProto,  
> lhsProto)) {
> +            (compare && ProtocolCompatibleWithProtocol(rhsProto,  
> lhsProto))) {
>           match = true;
>           break;
>         }
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits