[cfe-commits] r61098 - in /cfe/trunk/lib: AST/DeclCXX.cpp AST/StmtSerialization.cpp CodeGen/CGCXX.cpp

Eli Friedman eli.friedman at gmail.com
Tue Dec 16 12:06:42 PST 2008


Author: efriedma
Date: Tue Dec 16 14:06:41 2008
New Revision: 61098

URL: http://llvm.org/viewvc/llvm-project?rev=61098&view=rev
Log:
Warning fixes to operator precedence warnings.

Someone should double-check that I didn't somehow break ObjC 
serialization; I think the change there actually changes the semantics.


Modified:
    cfe/trunk/lib/AST/DeclCXX.cpp
    cfe/trunk/lib/AST/StmtSerialization.cpp
    cfe/trunk/lib/CodeGen/CGCXX.cpp

Modified: cfe/trunk/lib/AST/DeclCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DeclCXX.cpp?rev=61098&r1=61097&r2=61098&view=diff

==============================================================================
--- cfe/trunk/lib/AST/DeclCXX.cpp (original)
+++ cfe/trunk/lib/AST/DeclCXX.cpp Tue Dec 16 14:06:41 2008
@@ -90,13 +90,13 @@
            = Constructors->function_begin();
          Con != Constructors->function_end(); ++Con) {
     if (cast<CXXConstructorDecl>(*Con)->isCopyConstructor(Context, TypeQuals) &&
-        (TypeQuals & QualType::Const != 0))
+        (TypeQuals & QualType::Const) != 0)
       return true;
     }
   } else if (CXXConstructorDecl *Constructor 
                = dyn_cast<CXXConstructorDecl>(*Lookup.first)) {
     return Constructor->isCopyConstructor(Context, TypeQuals) &&
-           (TypeQuals & QualType::Const != 0);
+           (TypeQuals & QualType::Const) != 0;
   }
   return false;
 }

Modified: cfe/trunk/lib/AST/StmtSerialization.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/StmtSerialization.cpp?rev=61098&r1=61097&r2=61098&view=diff

==============================================================================
--- cfe/trunk/lib/AST/StmtSerialization.cpp (original)
+++ cfe/trunk/lib/AST/StmtSerialization.cpp Tue Dec 16 14:06:41 2008
@@ -1240,7 +1240,7 @@
   
   // Now read in the arguments.
   
-  if (flags & Flags == IsInstMeth)
+  if ((flags & Flags) == IsInstMeth)
     D.BatchReadOwnedPtrs(NumArgs+1, SubExprs, C);
   else {
     // Read the pointer for Cls/ClassName.  The Deserializer will handle the

Modified: cfe/trunk/lib/CodeGen/CGCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCXX.cpp?rev=61098&r1=61097&r2=61098&view=diff

==============================================================================
--- cfe/trunk/lib/CodeGen/CGCXX.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCXX.cpp Tue Dec 16 14:06:41 2008
@@ -28,7 +28,7 @@
 static void mangleDeclContextInternal(const DeclContext *D, std::string &S)
 {
   // FIXME: Should ObjcMethodDecl have the TranslationUnitDecl as its parent?
-  assert(!D->getParent() || isa<TranslationUnitDecl>(D->getParent()) && 
+  assert((!D->getParent() || isa<TranslationUnitDecl>(D->getParent())) && 
          "Only one level of decl context mangling is currently supported!");
   
   if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) {





More information about the cfe-commits mailing list