[cfe-commits] r60136 - in /cfe/trunk: include/clang/Lex/PTHLexer.h lib/Lex/PPLexerChange.cpp lib/Lex/PTHLexer.cpp

[Chris Lattner]

On Nov 26, 2008, at 4:38 PM, Ted Kremenek wrote:

> Author: kremenek
> Date: Wed Nov 26 18:38:24 2008
> New Revision: 60136
>
> URL: http://llvm.org/viewvc/llvm-project?rev=60136&view=rev
> Log:
> PTHLexer now owns the Token vector.

Ok.

>
> +  while (Tokens.push_back(Tok), Tok.isNot(tok::eof));

Very cute, but please write it the normal way with a do/while  
loop :).  Are you missing something that updates Tok?  It seems like  
an infinite loop.

-Chris